Skip to content

Ensure methods of Object are also available on interface objects#1284

Merged
lostmsu merged 2 commits intopythonnet:masterfrom
danabr:interface-exposes-methods-from-object
Nov 17, 2020
Merged

Ensure methods of Object are also available on interface objects#1284
lostmsu merged 2 commits intopythonnet:masterfrom
danabr:interface-exposes-methods-from-object

Conversation

@danabr
Copy link
Contributor

@danabr danabr commented Nov 17, 2020 •
edited
Loading

What does this implement/fix? Explain your changes.

Allows users to call ToString, GetHashCode and GetType on objects wrapped in interface objects.

Does this close any currently open issues?

No

Any other comments?

No

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself to AUTHORS
  • Updated the CHANGELOG

@codecov-io
Copy link

codecov-io commented Nov 17, 2020 •
edited
Loading

Codecov Report

Merging #1284 (3aae829) into master (2e6d12f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1284   +/-   ##
=======================================
  Coverage   87.97%   87.97%           
=======================================
  Files           1        1           
  Lines         291      291           
=======================================
  Hits          256      256           
  Misses         35       35
Flag Coverage Δ
setup_linux 64.94% <ø> (-0.35%) ⬇️
setup_windows 74.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e6d12f...3aae829. Read the comment docs.

@filmor
Copy link
Member

filmor commented Nov 17, 2020

Looks good to me, would you mind adding a Changelog entry for this?

@danabr
Copy link
Contributor Author

danabr commented Nov 17, 2020

I was thinking no change log entry was needed, as this was mostly a fallout from #1240 . But now I realize it was actually the case before that change as well for interface objects that had been explicitly created. I'll write something.

(Not sure what is up with the codecov though, it says coverage became worse for a file not touched by the PR?)

@lostmsu lostmsu merged commit 7870a9f into pythonnet:master Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@filmor filmor filmor approved these changes

@lostmsu lostmsu lostmsu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@danabr @codecov-io @filmor @lostmsu