Remove deprecated implicit assembly loading#1277
Merged
lostmsu merged 2 commits intopythonnet:masterfrom Nov 14, 2020
Merged
Conversation
filmor
approved these changes
Nov 11, 2020
Member
|
This needs to be communicated well on the 3.0 release. |
7ae19e2 to
060cccb
Compare
Member
Author
|
Moved one commit to a separate PR |
85c1ea4 to
aeae28e
Compare
aeae28e to
c2ce09d
Compare
Codecov Report
@@ Coverage Diff @@
## master #1277 +/- ##
==========================================
+ Coverage 87.62% 87.97% +0.34%
==========================================
Files 1 1
Lines 291 291
==========================================
+ Hits 255 256 +1
+ Misses 36 35 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Legacy behavior: `import Company.Product.Namespace` would search for `Company.Product.Namespace.dll` .NET assmebly, load it, and import the namespace. New behavior: User must always explicitly add assembly reference using `clr.AddReference` to `Company.Product.Namespace` prior to attempting import
c2ce09d to
1747b42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This removes deprecated logic of implicit assembly loading
Legacy behavior:
import Company.Product.Namespacewould search forCompany.Product.Namespace.dll.NET assmebly, load it, and import the namespace.New behavior:
User must always explicitly add assembly reference using
clr.AddReferencetoCompany.Product.Namespaceprior to attempting importChecklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG