fixed crash due to a decref of a borrowed reference in params array handling#1163
Merged
filmor merged 1 commit intopythonnet:masterfrom Jun 18, 2020
Merged
Conversation
…ms array handling
Codecov Report
@@ Coverage Diff @@
## master #1163 +/- ##
=======================================
Coverage 86.53% 86.53%
=======================================
Files 1 1
Lines 297 297
=======================================
Hits 257 257
Misses 40 40
Continue to review full report at Codecov.
|
filmor
approved these changes
Jun 18, 2020
AlexCatarino
pushed a commit
to QuantConnect/pythonnet
that referenced
this pull request
Jun 29, 2020
…ms array handling (pythonnet#1163)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
itemis a return value ofPyTuple_GetItemwhich returns borrowed reference.Hence it should not have been decref'ed