refactor: use more python3.9 syntax#3010
Conversation
|
Cool! I was thinking about this too 🙂 Well thinking of stopping the use of Thanks for doing this! Once we (in reality you) get this done, we should do a follow-up adding the commit to |
I was thinking of that as well, especially now that I see how big the diff is 😅 Maybe after this PR in case there's more rebasing etc. I'll just need to tweak the type hint tests for this now. |
|
I'll rebase this after #3083 to avoid too many conflicts there, and that will likely fix the typing issues altogether. |
|
@JohnVillalovos this one's a chunky one now, but mostly auto-generated 😅 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3010 +/- ##
==========================================
+ Coverage 97.25% 97.28% +0.03%
==========================================
Files 97 97
Lines 5932 5975 +43
==========================================
+ Hits 5769 5813 +44
+ Misses 163 162 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
JohnVillalovos
left a comment
There was a problem hiding this comment.
Thanks @nejch
A lot of work there.
Follow-up to #3005
Mostly done with
pyupgrade --py39-plusand some manual cleanup.