feat(api): add support for gitlab service account#2851
Merged
nejch merged 3 commits intopython-gitlab:mainfrom May 17, 2024
Merged
feat(api): add support for gitlab service account#2851nejch merged 3 commits intopython-gitlab:mainfrom
nejch merged 3 commits intopython-gitlab:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2851 +/- ##
==========================================
- Coverage 96.52% 96.51% -0.02%
==========================================
Files 90 91 +1
Lines 5872 5907 +35
==========================================
+ Hits 5668 5701 +33
- Misses 204 206 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
TimKnight-DWP
approved these changes
May 7, 2024
nejch
requested changes
May 7, 2024
Member
nejch
left a comment
There was a problem hiding this comment.
Thanks a lot @SachinKSingh28! Looks good. I just have a few comments 🙇
b1f676a to
148fb7e
Compare
77ca5e2 to
53dcd8c
Compare
Contributor
Author
|
@nejch addressed your comments! Ready for a review again. |
8b92a39 to
e68c9e2
Compare
e68c9e2 to
c628ab3
Compare
nejch
reviewed
May 17, 2024
nejch
reviewed
May 17, 2024
Member
|
Thanks again @SachinKSingh28, I applied a nit left over from the first round myself so we don't block this anymore. I'll squash and merge 👍 |
5256a9c to
61b4f7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for creating group service account: https://docs.gitlab.com/ee/api/groups.html#service-accounts
#2812