Improve CMD task for matrix strategy#101
Open
ihostage wants to merge 1 commit intoplayframework:mainfrom
Open
Conversation
mkurz
approved these changes
May 22, 2025
Member
There was a problem hiding this comment.
We can do that, just scrolling through it should be OK.
If you are 100% sure this works, please merge. (We can always roll back anyway)
3. In August 2022 GitHub had solved this problem but we missed this news.
I heard about that a couple of times actually when I was looking into some GitHub actions things but didn't look into it because things worked for us anyway.
Do you think now that GitHub allows us to call re-usable workflows in more depth that this somehow helps us to set up scheduled builds for the 3.0.x branch (started by the main branch actually).
4e60702 to
75f0d44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What the history? 📝
sbt-matrix.ymlandsbt.ymlintocmd.yml#19) in May 2022.So, we can use out-of-the-box feature of GitHub actions now and dramatically simplify our CMD task. Current documentation about using reusable workflow with matrix is here https://docs.github.com/en/actions/sharing-automations/reusing-workflows#using-a-matrix-strategy-with-a-reusable-workflow
@mkurz WDYT?
PS: I checked a new version for our core repo 15163869490. Moreover, I think the summary page for action looks more compacted now.