Skip to content

Package refactor#88

Merged
Jawnnypoo merged 2 commits intoparse-community:masterfrom
Jawnnypoo:package-refactor
Jul 23, 2018
Merged

Package refactor#88
Jawnnypoo merged 2 commits intoparse-community:masterfrom
Jawnnypoo:package-refactor

Conversation

@Jawnnypoo
Copy link
Member

@Jawnnypoo Jawnnypoo commented Jul 23, 2018

  • Move from com.parse to com.parse.livequery
  • Distribute with JitPack and use JitPack dependency of Parse-SDK

@codecov
Copy link

codecov bot commented Jul 23, 2018

Codecov Report

Merging #88 into master will increase coverage by 0.39%.
The diff coverage is 62.5%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #88      +/-   ##
============================================
+ Coverage     71.96%   72.35%   +0.39%     
  Complexity       84       84              
============================================
  Files            11       11              
  Lines           371      369       -2     
  Branches         25       24       -1     
============================================
  Hits            267      267              
+ Misses           88       86       -2     
  Partials         16       16
Impacted Files Coverage Δ Complexity Δ
...n/java/com/parse/livequery/LiveQueryException.java 51.85% <ø> (ø) 2 <0> (?)
.../com/parse/livequery/SubscribeClientOperation.java 100% <ø> (ø) 2 <0> (?)
...rc/main/java/com/parse/livequery/Subscription.java 97.5% <ø> (ø) 17 <0> (?)
...java/com/parse/livequery/SubscriptionHandling.java 100% <ø> (ø) 0 <0> (?)
...java/com/parse/livequery/ParseLiveQueryClient.java 16.66% <ø> (ø) 0 <0> (?)
...om/parse/livequery/OkHttp3SocketClientFactory.java 32.65% <ø> (ø) 2 <0> (?)
...main/java/com/parse/livequery/WebSocketClient.java 100% <ø> (ø) 0 <0> (?)
...om/parse/livequery/UnsubscribeClientOperation.java 100% <100%> (ø) 2 <1> (?)
...main/java/com/parse/livequery/ClientOperation.java 100% <100%> (ø) 1 <1> (?)
...va/com/parse/livequery/ConnectClientOperation.java 100% <100%> (ø) 2 <1> (?)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fb2aed...a6d6b58. Read the comment docs.

@Jawnnypoo Jawnnypoo requested a review from mmimeault July 23, 2018 15:10
@Jawnnypoo
Copy link
Member Author

Jawnnypoo commented Jul 23, 2018

@mmimeault Do you think you can review this for me?

mmimeault
mmimeault approved these changes Jul 23, 2018
View reviewed changes
Copy link
Contributor

@mmimeault mmimeault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The refactor looks good.
For the jitpack part I can't judge, I will trust you on that one.

Just for your information about the /* package */ you removed in the code:
I started using that after seeing that in some projects. Normally you are really explicit with "public" or "private", but when you want to be "package", having no keyword is not "explicit'. You don't if it's a mistake or on purpose. Since I found that nice trick /* package */, I'm using it. And since I started this project from 0, I thought it would be nice for the open source community.

@Jawnnypoo
Copy link
Member Author

Jawnnypoo commented Jul 23, 2018

I see. Yeah, that makes sense about /* package */. The problem that I have seen with Parse-SDK-Android and the reason I have been removing it from there is that it completely throws off the JavaDocs and makes them unassociated from whatever method/class/field you are attempted to place them on.

@Jawnnypoo Jawnnypoo merged commit 508b9a0 into parse-community:master Jul 23, 2018
@Jawnnypoo Jawnnypoo deleted the package-refactor branch July 23, 2018 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mmimeault mmimeault mmimeault approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Jawnnypoo @mmimeault