Improved pull request "Files Changed" experience feedback #163932
Replies: 2812 comments 1116 replies
-
|
I would like to be able to scroll through the Pull Request while the comment modal is open. Reason: When a comment is outdated, we need to look at the current version to check if it actually addresses the comment. I really love this feature! THANK YOU!!! |
Beta Was this translation helpful? Give feedback.
-
|
Update: I just found out that it appears when there's enough space (1280px width). Here's the updated feedback. I'd like to see the branch name in the sticky header at all times so that I can easily copy it when I'm reviewing a PR. I wrote the following before thoroughly experimenting. I'd like to see the branch name when the sticky header is shown (i.e., when you've scrolled to the bottom). The reason is that when I'm reviewing a long PR and want to checkout the branch to continue reviewing it locally, I have to go back all the way up to see or copy the branch name and then go back to where I left off. |
Beta Was this translation helpful? Give feedback.
-
|
I find the comment indicators in the sidebar really useful. It might also be useful to have them in the "diff file header." It's very useful when you've marked a file as "viewed" because you can see how many comments it has as you're scrolling without having to expand it. |
Beta Was this translation helpful? Give feedback.
-
This is really cool. Is it also possible to seamlessly toggle hiding white spaces? If that's achievable without doing a refresh would be amazing. |
Beta Was this translation helpful? Give feedback.
-
|
Clicking a line number always assumes you want to add a comment. In the previous experience it only changes the URL to have deep linking. |
Beta Was this translation helpful? Give feedback.
-
|
This is so much better, I might go back from reviewing with the VSCode extension now 🚀 I love the new alerts panel, unfortunately it looks like pressing Maybe we could have some grouping or clustering in the alerts panel in the future. |
Beta Was this translation helpful? Give feedback.
-
|
I would love to see the file tree sorted alphabetically with folders on top, then files. It is quite jarring to have changed files in the middle of folders when viewing the file tree currently. Example of current state Example of desired state This would mirror how the majority of developers view the code in their IDE |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Hi, I would like to play around with this, but I'm not seeing the opt-in mentioned in
Am I missing something? |
Beta Was this translation helpful? Give feedback.
-
|
The tab for |
Beta Was this translation helpful? Give feedback.
-
|
Not sure if this is the sort of feedback you're after, but the |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
|
On the Files changed tab I can only see 19 files out of 66. Why? |
Beta Was this translation helpful? Give feedback.
-
|
I used to be able to click on a useful link to see the submodule diff in PRs but now its just plain text. Could we have that back pls? |
Beta Was this translation helpful? Give feedback.
-
|
It doesn't always seem to remember if hide whitespace was turned on. |
Beta Was this translation helpful? Give feedback.
-
|
We are experiencing reliability issues when reviewing PRs that have files with large diffs an example PR that has this issue has only 6 files changed, but one with 16K lines of diff It looks like in the new experience we render large diffs by default, where previously those would instead have a button for "Show diff" This is causing the tab to hang and become unresponsive |
Beta Was this translation helpful? Give feedback.
-
|
One thing I have noticed during longer review sessions is that it can sometimes be harder to keep track of where comments are located or how far along I am in the review when moving between files. A lightweight review summary or some kind of persistent indicator showing files with unresolved comments could help reviewers maintain context without losing the performance benefits of virtualization. |
Beta Was this translation helpful? Give feedback.
-
|
What happened to the code owners drop downs? We use those quite heavily |
Beta Was this translation helpful? Give feedback.
-
|
I'm having difficulty swapping between split and unified view. |
Beta Was this translation helpful? Give feedback.
-
|
Filtering out resolved and/or outdated comments is not working consistently. When resolved comments still show up after filtering, clicking the "Resolve comment" icon gives "Failed to resolve thread" error. |
Beta Was this translation helpful? Give feedback.
-
|
I'd like an option to indicate my "disposition" for a given comment that I leave as part of review. For example, I might be "discussing", "informing", or "blocking". |
Beta Was this translation helpful? Give feedback.
-
|
I cannot find code suggestion anywhere and hand-coding doesn't work |
Beta Was this translation helpful? Give feedback.
-
|
We maintain several WordPress sites and our monthly update PRs (core + plugin updates) routinely exceed 3,000 files. The previous experience allowed us to review the full file tree even on large PRs. Since the new Files Changed experience became the default on January 22, we can no longer see the complete file list. We need at minimum the ability to browse the full file tree, even if individual diffs aren't rendered. What is the recommended workflow for reviewing PRs of this size? |
Beta Was this translation helpful? Give feedback.
-
|
I am seing PRs which:
|
Beta Was this translation helpful? Give feedback.
-
|
Please make alt+click work for fully expanding/collapsing a file tree and its children. This is a pretty general UI convention and is already working for expanding/collapsing all the file changes, but not in the file tree. |
Beta Was this translation helpful? Give feedback.
-
|
Sorry if this has already been mentioned, but the placement of the "next/prev" buttons makes no sense to me. I think it would make much more sense if they were still placed in the top-right, as they are on the "classic" design, rather than below the commit message. The new placement is continually making me think that it is attached to the commit message somehow in a way that makes it take longer for me to figure out what the actual commit message was. There is tons of room for it off to the side, especially on wider screens, why not place it there? This makes even less sense when you realize that the "next/prev" buttons Additionally, having the buttons below the message makes the whole block unnecessarily take up a ton of valuable vertical space. In fact, the new commit design is taller than the old design, despite having less info. Current new design:
Proposed change:
You might even consider swapping the "next/prev" and "Browse files" buttons. (Screenshots from simon-abbott/testing@d6d6754?new_files_changed=true) |
Beta Was this translation helpful? Give feedback.
-
|
Sometimes syntax highlighting doesn't work, or is slow to apply. I had to refresh the page a couple of times to get highlighting to work, and it was a very small PR.
|
Beta Was this translation helpful? Give feedback.
-
|
Please add the ability to abandon a review in the new version of the UI as well. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Please add back the "Only Files Owned by You" filter. Without it, the new experience is frustrating when reviewing large PRs worked on by multiple teams. |
Beta Was this translation helpful? Give feedback.


























Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
About the new experience
This updated experience focuses on performance, accessibility, and user productivity. Read more in the changelog.
Tip
If you are not already using the new experience, click the ✨Try the new experience in the upper-right corner of the classic "Files changed" page. You can easily switch back from the Preview menu.
✨ What's new
If you are coming from the classic experience, the new experience should feel familiar but adds some significant improvements:
✨ Updates
See what's been fixed and improved since the launch of the public preview:
🟡 Limitations
As of the initial public preview release, there are some temporary limitations that will be addressed over time:
While our previous experience had hard limits on large PRs, this new experience is being built to scale. That said, we’re increasing our limits incrementally. To start with, our additional current limitations are:
How you can help
Thanks for helping us build a better review experience—we read every comment!
Beta Was this translation helpful? Give feedback.
All reactions