Ensures that commits from parent(*) has a repository#1658
Merged
implausible merged 1 commit intonodegit:masterfrom Apr 17, 2019
Merged
Ensures that commits from parent(*) has a repository#1658implausible merged 1 commit intonodegit:masterfrom
implausible merged 1 commit intonodegit:masterfrom
Conversation
Commit has functions that requires a reference to a repository to run. Because parent(*) was simply calling out to libgit2's git_commit_parent directly, its repo field was not being set. Creating a wrapper in the Commit class and assigning a repository to the object before returning it will fix this problem. Signed-off-by: Remy Suen <remy.suen@gmail.com>
implausible
approved these changes
Apr 17, 2019
Member
Author
|
Thanks for reviewing this, @implausible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit has functions that requires a reference to a repository to run. Because
parent(*)was simply calling out to libgit2'sgit_commit_parentdirectly, itsrepofield was not being set.Creating a wrapper in the
Commitclass and assigning a repository to the object before returning it will fix this problem.Fixes #1653.