TST: Isolate Qt tests in subprocesses to fix QApplication leakage #31072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5ce82b7.
timhoffm
requested changes
Feb 4, 2026
Member
timhoffm
left a comment
There was a problem hiding this comment.
Technical note:
- Please remove all unrelated style changes. We don't want style churn and no reviewer will invest time to spot the actual logic changes in a wall trival style changes.
The PR explantion looks AI-generated. Please make sure to comply with our AI policy.
https://matplotlib.org/devdocs/devel/contribute.html#restrictions-on-generative-ai-usage
Author
|
@timhoffm I have reverted all unrelated style changes as requested. Regarding the AI policy: Apologies for the confusion. Since this is my first open-source contribution, I was eager to ensure everything was perfect. I want to confirm that I fully understood the entire logic and wrote the fix myself. I only used AI tools to help polish my English phrasing as a non-native speaker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I isolated the Qt tests into subprocesses to prevent QApplication memory leaks.
Change 1. Moved Qt test logic into subprocess.run.
Change 2. Added env=os.environ to fix the DISPLAY variable error on Linux CI.
Change 3. Reverted all unrelated style changes.