Skip to content

CloudWatch V2: Move tagging functionality into separate methods to enable their overriding in pro version #13748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
k-a-il wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

CloudWatch V2: Move tagging functionality into separate methods to enable their overriding in pro version #13748

k-a-il wants to merge 1 commit into from
+37 −7

Conversation

@k-a-il
Copy link
Contributor

@k-a-il k-a-il commented Feb 12, 2026

Motivation

This PR moves tagging logic to separate methods on the CloudWatch V2 Provider class to enable their overriding in pro version.
These methods will be overridden in the Pro version, where CloudWatch V2 will be integrated with the new ResourceGroupsTagging plugin. This integration will enable CloudWatch resources to be tagged and allow tags to be retrieved through the Resource Groups Tagging service.

Changes

  • Moves tagging logic into separate methods

Tests

Related

FLC-280

@k-a-il k-a-il added this to the 4.14 milestone Feb 12, 2026
@k-a-il k-a-il self-assigned this Feb 12, 2026
@k-a-il k-a-il added semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Feb 12, 2026
@github-actions
Copy link

github-actions bot commented Feb 12, 2026

Test Results - Preflight, Unit

23 099 tests  ±0   21 237 ✅ ±0   6m 15s ⏱️ -1s
     1 suites ±0    1 862 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 365b9cc. ± Comparison against base commit 2046dff.

@github-actions
Copy link

github-actions bot commented Feb 12, 2026

Test Results - Alternative Providers

180 tests   - 1 093    39 ✅  - 687   2m 31s ⏱️ - 28m 35s
  1 suites  -     3   141 💤  - 406 
  1 files    -     3     0 ❌ ±  0 

Results for commit 365b9cc. ± Comparison against base commit 2046dff.

This pull request removes 1093 tests. 
tests.aws.services.cloudformation.api.test_changesets ‑ test_autoexpand_capability_requirement
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_and_then_remove_non_supported_resource_change_set
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_and_then_remove_supported_resource_change_set
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_and_then_update_refreshes_template_metadata
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_change_set_create_existing
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_change_set_invalid_params
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_change_set_missing_stackname
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_change_set_no_changes
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_change_set_update_nonexisting
tests.aws.services.cloudformation.api.test_changesets ‑ test_create_change_set_update_without_parameters
…

@github-actions
Copy link

github-actions bot commented Feb 12, 2026

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   2m 52s ⏱️ -12s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 365b9cc. ± Comparison against base commit 2046dff.

@github-actions
Copy link

github-actions bot commented Feb 12, 2026

Test Results (amd64) - Integration, Bootstrap

    5 files  ±    0      5 suites  ±0   1h 4m 27s ⏱️ - 1h 31m 33s
1 266 tests  - 4 346  1 190 ✅  - 3 914  76 💤  - 432  0 ❌ ±0 
1 272 runs   - 4 346  1 190 ✅  - 3 914  82 💤  - 432  0 ❌ ±0 

Results for commit 365b9cc. ± Comparison against base commit 2046dff.

This pull request removes 4346 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

@github-actions
Copy link

github-actions bot commented Feb 12, 2026

LocalStack Community integration with Pro

    2 files      2 suites   48m 1s ⏱️
1 242 tests 1 164 ✅ 78 💤 0 ❌
1 244 runs  1 164 ✅ 80 💤 0 ❌

Results for commit 365b9cc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pinzon pinzon Awaiting requested review from pinzon pinzon will be requested when the pull request is marked ready for review pinzon is a code owner

@steffyP steffyP Awaiting requested review from steffyP steffyP will be requested when the pull request is marked ready for review steffyP is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@k-a-il k-a-il

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

4.14

Development

Successfully merging this pull request may close these issues.

1 participant

@k-a-il