fix(dynamodbstreams): support ShardFilter on DescribeStream #13670
+46
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement CHILD_SHARDS ShardFilter in DescribeStream (v1/Kinesis provider) - Normalize ParentShardId to DynamoDB format for filter and response consistency - Add test_describe_stream_with_shard_filter
- Implement CHILD_SHARDS ShardFilter in DescribeStream (v1/Kinesis provider) - Add test_describe_stream_with_shard_filter
Contributor
localstack-bot
left a comment
There was a problem hiding this comment.
Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
localstack-bot
added a commit
that referenced
this pull request
Jan 31, 2026
Author
|
Hi @giograno , please take a look and let me know your thoughts. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The DynamoDB Streams
DescribeStreamAPI accepts an optionalShardFilterparameter (e.g.Type: CHILD_SHARDS,ShardId) but LocalStack ignored it and always returned all shards. Callers (e.g. stream consumers that need to discover child shards after a parent shard closes) could not use the API as documented by AWS.This PR implements support for the
CHILD_SHARDSShardFilter type so that whenShardFilteris provided withType: CHILD_SHARDSand aShardId, the response contains only shards whoseParentShardIdmatches the given shard ID.Changes
localstack-core/localstack/services/dynamodbstreams/provider.pydescribe_stream, after applyingExclusiveStartShardIdpagination, applyShardFilterwhen present.ShardFilter.TypeisCHILD_SHARDSandShardFilter.ShardIdis set, filter the returned shards to only those whoseParentShardIdequals the given shard ID.Tests
tests/aws/services/dynamodbstreams/test_dynamodb_streams.pytest_describe_stream_with_shard_filter(@markers.aws.only_localstack):describe_streamwithout filter to get initial shards.describe_streamwithShardFilter={"Type": "CHILD_SHARDS", "ShardId": parent_shard_id}.ParentShardIdequals the given ID (or an empty list when there are no children).Related