Skip to content

Change error code from 500 to 501 in case plugin is not available in users license#13344

Merged
sannya-singal merged 2 commits intomainfrom
plugin-disabled-501
Nov 17, 2025
Merged

Change error code from 500 to 501 in case plugin is not available in users license#13344
sannya-singal merged 2 commits intomainfrom
plugin-disabled-501

Conversation

@sannya-singal
Copy link
Contributor

@sannya-singal sannya-singal commented Nov 6, 2025 •
edited
Loading

Motivation

Change error code from 500 to 501 in case the plugin is not part of the active license agreement and modify the error message to plugin details.

Eg: localstack.aws.api.core.CommonServiceException: exception while calling cloudtrail.CreateTrail: plugin localstack.aws.provider:cloudtrail:pro is disabled, reason: This feature is not part of the active license agreement should return 501.

Changes

Set status code to 501 if when creating the error response in the handler and error message removes plugin details.

Tests

This was tested by manually intervening the license activation process in the core repo by not updating, validating and saving the license file.

Related

Fixes FLC-97

@sannya-singal sannya-singal self-assigned this Nov 6, 2025
@sannya-singal sannya-singal requested a review from thrau as a code owner November 6, 2025 07:12
@sannya-singal sannya-singal added semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Nov 6, 2025
@sannya-singal sannya-singal marked this pull request as draft November 6, 2025 07:12
@sannya-singal sannya-singal requested review from k-a-il and removed request for thrau November 6, 2025 07:26
@sannya-singal sannya-singal marked this pull request as ready for review November 6, 2025 07:27
@github-actions
Copy link

github-actions bot commented Nov 6, 2025 •
edited
Loading

Test Results - Preflight, Unit

22 309 tests  +31   20 555 ✅ +29   6m 20s ⏱️ - 9m 4s
     1 suites ± 0    1 754 💤 + 2 
     1 files   ± 0        0 ❌ ± 0 

Results for commit 27d94db. ± Comparison against base commit 3262ccd.

This pull request removes 13 and adds 44 tests. Note that renamed tests count towards both. 
tests.unit.utils.test_catalog.TestAwsCatalog ‑ test_build_cfn_catalog_resources
tests.unit.utils.test_catalog.TestAwsCatalog ‑ test_get_cfn_resource_status[AWS::Athena::CapacitiesReservation-athena-SUPPORTED_WITH_LICENSE_UPGRADE]
tests.unit.utils.test_catalog.TestAwsCatalog ‑ test_get_cfn_resource_status[AWS::NonExistentService::NonExistent-nonexistentservice-NOT_SUPPORTED]
tests.unit.utils.test_catalog.TestAwsCatalog ‑ test_get_cfn_resource_status[AWS::S3::Bucket-s3-AVAILABLE]
tests.unit.utils.test_catalog.TestAwsCatalog ‑ test_get_cfn_resource_status[AWS::S3::NonExistent-s3-NOT_SUPPORTED]
tests.unit.utils.test_catalog.TestAwsCatalog ‑ test_get_service_status[athena-SUPPORTED_WITH_LICENSE_UPGRADE]
tests.unit.utils.test_catalog.TestAwsCatalog ‑ test_get_service_status[nonexistent-NOT_SUPPORTED]
tests.unit.utils.test_catalog.TestAwsCatalog ‑ test_get_service_status[s3-SUPPORTED]
tests.unit.utils.test_catalog.TestAwsCatalog ‑ test_get_service_status_with_empty_operation
tests.unit.utils.test_catalog.TestAwsCatalog ‑ test_get_service_status_with_only_one_emulator_type
…

tests.unit.aws.api.test_asf_providers ‑ test_provider_signatures[KinesisProvider-KinesisApi-describe_account_settings]
tests.unit.aws.api.test_asf_providers ‑ test_provider_signatures[KinesisProvider-KinesisApi-update_account_settings]
tests.unit.aws.api.test_asf_providers ‑ test_provider_signatures[KinesisProvider-KinesisApi-update_stream_warm_throughput]
tests.unit.aws.api.test_asf_providers ‑ test_provider_signatures[OpensearchProvider-OpensearchApi-get_default_application_setting]
tests.unit.aws.api.test_asf_providers ‑ test_provider_signatures[OpensearchProvider-OpensearchApi-put_default_application_setting]
tests.unit.aws.test_service_router ‑ test_service_router_works_for_every_service[cloudfront-rest-xml-DeleteResourcePolicy]
tests.unit.aws.test_service_router ‑ test_service_router_works_for_every_service[cloudfront-rest-xml-GetResourcePolicy]
tests.unit.aws.test_service_router ‑ test_service_router_works_for_every_service[cloudfront-rest-xml-ListDistributionsByOwnedResource]
tests.unit.aws.test_service_router ‑ test_service_router_works_for_every_service[cloudfront-rest-xml-PutResourcePolicy]
tests.unit.aws.test_service_router ‑ test_service_router_works_for_every_service[cloudfront-rest-xml-UpdateAnycastIpList]
…

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 6, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 20s ⏱️ -6s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 27d94db. ± Comparison against base commit 3262ccd.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 6, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files  ± 0      5 suites  ±0   2h 40m 38s ⏱️ + 1m 18s
5 312 tests +44  4 773 ✅ +34  539 💤 +10  0 ❌ ±0 
5 318 runs  +44  4 773 ✅ +34  545 💤 +10  0 ❌ ±0 

Results for commit 27d94db. ± Comparison against base commit 3262ccd.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 6, 2025 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ± 0      2 suites  ±0   2h 0m 37s ⏱️ + 1m 0s
4 938 tests +44  4 559 ✅ +34  379 💤 +10  0 ❌ ±0 
4 940 runs  +44  4 559 ✅ +34  381 💤 +10  0 ❌ ±0 

Results for commit 27d94db. ± Comparison against base commit 3262ccd.

♻️ This comment has been updated with latest results.

k-a-il
k-a-il reviewed Nov 6, 2025
View reviewed changes
k-a-il
k-a-il reviewed Nov 11, 2025
View reviewed changes
k-a-il
k-a-il reviewed Nov 11, 2025
View reviewed changes
k-a-il
k-a-il requested changes Nov 11, 2025
View reviewed changes
Copy link
Contributor

@k-a-il k-a-il left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this issue 🚀

@sannya-singal sannya-singal requested a review from k-a-il November 13, 2025 09:12
k-a-il
k-a-il approved these changes Nov 14, 2025
View reviewed changes
Copy link
Contributor

@k-a-il k-a-il left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sannya-singal sannya-singal merged commit 9dfd4e1 into main Nov 17, 2025
43 checks passed
@sannya-singal sannya-singal deleted the plugin-disabled-501 branch November 17, 2025 05:03
@k-a-il k-a-il mentioned this pull request Jan 27, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@k-a-il k-a-il k-a-il approved these changes

Assignees

@sannya-singal sannya-singal

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sannya-singal @k-a-il