Add JSpecify annotations to 14 classes in graphql.language package (final batch)#4221
Draft
Add JSpecify annotations to 14 classes in graphql.language package (final batch)#4221
Conversation
# Conflicts: # src/main/java/graphql/relay/DefaultConnectionCursor.java # src/main/java/graphql/relay/DefaultEdge.java # src/main/java/graphql/relay/SimpleListConnection.java
Co-authored-by: dondonz <13839920+dondonz@users.noreply.github.com>
Co-authored-by: dondonz <13839920+dondonz@users.noreply.github.com>
Co-authored-by: dondonz <13839920+dondonz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add JSpecify annotations to 14 classes in graphql.language package
Add JSpecify annotations to 14 classes in graphql.language package (final batch)
Jan 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes JSpecify annotation coverage for the
graphql.languagepackage by annotating the remaining 14 classes.Changes
Annotated classes:
SDLNamedDefinition,Selection,SelectionSetContainer,TypeDefinitionTypeKindScalarTypeDefinition,ScalarTypeExtensionDefinition,SchemaDefinition,SchemaExtensionDefinition,SelectionSet,TypeName,UnionTypeDefinition,UnionTypeExtensionDefinition,VariableDefinitionPattern applied:
@NullMarkedat class level@NullUnmarkedon static Builder classes@Nullableon fields/parameters that accept null:SourceLocation,Description,Value defaultValue,SelectionSetassertNotNull()wrappingdeepCopy()results passed to constructors expecting non-null listsRipple effect fix:
Anonymizer.javato useassertNotNull()when passing condition strings toTypeNameconstructor (now requires non-null after annotation)Exemption list:
JSpecifyAnnotationsCheck.groovyOriginal prompt
This pull request was created from Copilot chat.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.