Fix bug in "items" function#115
Merged
corona10 merged 2 commits intogo-python:masterfrom Nov 18, 2019
Sungmin-Joo:master
Merged
Fix bug in "items" function#115corona10 merged 2 commits intogo-python:masterfrom Sungmin-Joo:master
corona10 merged 2 commits intogo-python:masterfrom
Sungmin-Joo:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
==========================================
+ Coverage 72.6% 72.61% +<.01%
==========================================
Files 60 60
Lines 11912 11915 +3
==========================================
+ Hits 8649 8652 +3
Misses 2736 2736
Partials 527 527
Continue to review full report at Codecov.
|
corona10
reviewed
Oct 8, 2019
py/tests/dict.py
Outdated
| assert v == "b" | ||
| if k == "c": | ||
| assert v == 5.5 | ||
| assertRaises(TypeError,a.items,'a') |
Collaborator
There was a problem hiding this comment.
nit Please follow PEP8 when you writing python code.
assertRaises(TypeError, a.items, 'a')
Contributor
Author
|
@corona10 |
Contributor
Author
|
@corona10 |
corona10
approved these changes
Nov 18, 2019
Collaborator
corona10
left a comment
There was a problem hiding this comment.
Sorry for the delay
LGTM
Collaborator
|
@Sungmin-Joo Next time, I recommend you to work on the sperate branch rather than master branch :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #101