Reinit critical parking_lot locks after fork in child process#6972
Draft
youknowone wants to merge 1 commit intoRustPython:mainfrom
Draft
Reinit critical parking_lot locks after fork in child process#6972youknowone wants to merge 1 commit intoRustPython:mainfrom
youknowone wants to merge 1 commit intoRustPython:mainfrom
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
After fork(), only the calling thread survives. Locks held by dead parent threads stay locked forever, causing deadlocks when the child tries to acquire them. - Add reinit_pymutex_after_fork / reinit_pyrwlock_after_fork utilities that zero the raw lock bytes directly - Reset all PyGlobalState locks, thread-handle locks, and the import lock (IMP_LOCK) at the start of py_os_after_fork_child - Remove unlock() calls from _at_fork_reinit — unlock_slow() would attempt to unpark stale waiters from dead threads - Replace try_lock() with lock() in after_fork_child now that locks are guaranteed to be in unlocked state Note that this does not resolve any data deadlock issue
5b9758b to
5f8fb6a
Compare
Contributor
📦 Library DependenciesThe following Lib/ modules were modified. Here are their dependencies: [x] lib: cpython/Lib/asyncio dependencies:
dependent tests: (8 tests)
Legend:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #6963