fix(RootLayout): Close shade cover when topmost popup doesn't need it#11007
Merged
NathanWalker merged 1 commit intoNativeScript:mainfrom Dec 10, 2025
Merged
Conversation
|
View your CI Pipeline Execution ↗ for commit 1d42be8
☁️ Nx Cloud last updated this comment at |
NathanWalker
approved these changes
Dec 10, 2025
farfromrefug
pushed a commit
to Akylas/NativeScript
that referenced
this pull request
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
When a RootLayout popup closes, its shade cover remains even if the new topmost popup doesn't need it.
What is the new behavior?
Close RootLayout shade cover if it's not needed by new topmost popup view.