fix(ios): Added null-check for action bar updates#11003
Merged
NathanWalker merged 1 commit intoNativeScript:mainfrom Dec 5, 2025
Merged
fix(ios): Added null-check for action bar updates#11003NathanWalker merged 1 commit intoNativeScript:mainfrom
NathanWalker merged 1 commit intoNativeScript:mainfrom
Conversation
|
View your CI Pipeline Execution ↗ for commit f42f0da
☁️ Nx Cloud last updated this comment at |
NathanWalker
approved these changes
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
When a nested Frame is removed from native view tree, it trigger the view controller children lifecycle and that results in action bar updates, even though the Frame view controller is already disposed.
What is the new behavior?
Added a null check for frame view controller, also improved
setViewControllersAnimatedto accept null or empty array parameters.